mirror of
https://github.com/bdbrown4/peltier.io.git
synced 2026-11-07 10:58:28 +00:00
benbrownandClaude Opus 4.8
899d55f4b6
An adversarial audit found the enforcement story ahead of the code: gates that were documented as hard gates were advisory, manual, or absent, and several human-facing claims outran the machine record. This makes the claims true. High findings - Differential fuzz was documentation, not enforcement: verdict hardcoded fuzz_iters=0 and diff-test hardcoded the gate to Skipped, while the case studies claimed 10k-iteration fuzz on the same wins. Fuzz is now a real pipeline gate (strict FUZZ-RESULT contract, executed count recorded), and it is inherently baseline-vs-candidate, so it runs on the accept path and reports Skipped in the standalone `just gates` flow. New hard rule: a machine `accepted` verdict is impossible unless the fuzz gate actually passed — otherwise it caps at needs-human-review. - The agent's system prompt claimed FP/concurrency/unsafe patches were "routed to human review automatically". No such mechanism existed. Added a conservative lexical risk classifier (crates/verdict/src/risk.rs) that forces needs-human-review on any would-be accept carrying those signals; fp-tolerance equivalence always signals. - The local verdict path ran agent-influenced code unsandboxed. It now runs under scripts/no-net.sh (network namespace) and fails closed. Upstream test suites are hash-verified against corpora/<t>/TESTSUITE.sha256 when present (scripts/pin-testsuite.sh generates them). Also fixed, found while fixing the above - The pipeline script's `set -e` was inert (brace group as the left operand of `&&`), so a failing candidate build did not abort the run and verdict could bench a stale binary. Now a scoped subshell whose status is branched on at top level. - A wrapper that exits before exec'ing (no-net.sh refusing, bad wrapper path) stranded RUNNING.lock and left read_verdict polling forever. Failure accounting now lives outside the wrapper. - harnessd's patch allowlist ignored git rename/copy headers and --no-prefix diffs; the rename-escape case is now a committed regression test. - The workspace did not compile on Windows (ungated Unix APIs). cfg-gated; 71 portable tests now run on both platforms. - pin-check regenerated the corpus manifest instead of verifying it; it is now verify-only, with a deliberate `just pin-corpus` to re-pin. - Max RSS is captured per run on Unix; PMU counters are opt-in diagnostics (compare --perf-stat), never part of the accept decision. Docs now match the code, including what is NOT yet enforced: no target ships a TESTSUITE.sha256 pin, no target declares [build].tsan, and matmul is not wired to the fp-tolerance gate — each is stated as mechanized-but-inert rather than done. Corrected the stale "33 ledger rows" (34), the playbook's class-3 cJSON win (rejected), adversarial-review.md's sanitizer-separation claim (five accepted rows carry sanitizers_clean=false), the unsupported "40,000 requests" figure, and the blanket "historical rows record fuzz_iters=0" (8 of 10; phase0-tokei-002/-003 record 4,332). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
47 lines
2.3 KiB
TOML
47 lines
2.3 KiB
TOML
# comrak — CommonMark + GFM parser/renderer (Rust)
|
|
# Selection vs SPEC §6: CPU-bound parser; upstream spec test suite;
|
|
# upstream-defined benchmark workload (benches/bench.sh, Pro Git book);
|
|
# BSD-2-Clause; active, no dedicated perf team.
|
|
|
|
[source]
|
|
repo = "https://github.com/kivikakk/comrak.git"
|
|
commit = "45c1995fe922b6d5782b971a377721f088025fc8" # v0.53.0
|
|
license = "BSD-2-Clause"
|
|
|
|
[source.submodules]
|
|
# Upstream benchmark corpus (Pro Git book, all translations).
|
|
"vendor/progit" = { repo = "https://github.com/progit/progit.git", commit = "61833a527c6ac0c44cc40793c034b81599c25efc" }
|
|
|
|
[fetch]
|
|
# targets/*/workspace is gitignored; reproduce it with:
|
|
# git clone <repo> workspace && git -C workspace checkout <commit>
|
|
# git clone <submodule repo> workspace/vendor/progit && git -C ... checkout <commit>
|
|
|
|
[build]
|
|
baseline = "CARGO_TARGET_DIR={out} cargo build --release --manifest-path targets/comrak/workspace/Cargo.toml"
|
|
binary = "{out}/release/comrak"
|
|
sanitizer = "CARGO_TARGET_DIR={out} RUSTFLAGS='-Zsanitizer=address' cargo +nightly build --target x86_64-unknown-linux-gnu --manifest-path targets/comrak/workspace/Cargo.toml"
|
|
sanitizer_binary = "{out}/x86_64-unknown-linux-gnu/debug/comrak"
|
|
|
|
[bench]
|
|
# Upstream workload (benches/bench.sh): full Pro Git book through the
|
|
# renderer, output discarded. Corpus pinned via corpora/comrak/MANIFEST.sha256.
|
|
command = "cat corpora/comrak/progit.md | {binary} > /dev/null"
|
|
workload = "Pro Git book, all translations, 11.0 MB concatenated markdown, single stream"
|
|
|
|
[gates]
|
|
tests = "cargo test --release --manifest-path targets/comrak/workspace/Cargo.toml"
|
|
# Golden replay: corpus through the binary, stdout must be byte-identical.
|
|
golden = "cat corpora/comrak/progit.md | {binary}"
|
|
# Differential fuzz, pipeline-integrated: diff-test substitutes {iters},
|
|
# {baseline} (the pristine binary the accept path rebuilds) and {candidate},
|
|
# then parses the script's final FUZZ-RESULT line. The harness owns where the
|
|
# pristine build lands, so the script takes the baseline from argv and never
|
|
# hardcodes a path; paths may be repo-root-relative or absolute.
|
|
fuzz = "python3 scripts/diff-fuzz-comrak.py targets/comrak/fuzz-work {iters} {baseline} {candidate}"
|
|
|
|
[corpus]
|
|
manifest = "corpora/comrak/MANIFEST.sha256"
|
|
root = "corpora/comrak"
|
|
golden_sha256 = "corpora/comrak/GOLDEN.sha256"
|