mirror of
https://github.com/bdbrown4/peltier.io.git
synced 2026-11-07 10:58:28 +00:00
gates: close the audit findings — enforce the gates the docs claimed
An adversarial audit found the enforcement story ahead of the code: gates that were documented as hard gates were advisory, manual, or absent, and several human-facing claims outran the machine record. This makes the claims true. High findings - Differential fuzz was documentation, not enforcement: verdict hardcoded fuzz_iters=0 and diff-test hardcoded the gate to Skipped, while the case studies claimed 10k-iteration fuzz on the same wins. Fuzz is now a real pipeline gate (strict FUZZ-RESULT contract, executed count recorded), and it is inherently baseline-vs-candidate, so it runs on the accept path and reports Skipped in the standalone `just gates` flow. New hard rule: a machine `accepted` verdict is impossible unless the fuzz gate actually passed — otherwise it caps at needs-human-review. - The agent's system prompt claimed FP/concurrency/unsafe patches were "routed to human review automatically". No such mechanism existed. Added a conservative lexical risk classifier (crates/verdict/src/risk.rs) that forces needs-human-review on any would-be accept carrying those signals; fp-tolerance equivalence always signals. - The local verdict path ran agent-influenced code unsandboxed. It now runs under scripts/no-net.sh (network namespace) and fails closed. Upstream test suites are hash-verified against corpora/<t>/TESTSUITE.sha256 when present (scripts/pin-testsuite.sh generates them). Also fixed, found while fixing the above - The pipeline script's `set -e` was inert (brace group as the left operand of `&&`), so a failing candidate build did not abort the run and verdict could bench a stale binary. Now a scoped subshell whose status is branched on at top level. - A wrapper that exits before exec'ing (no-net.sh refusing, bad wrapper path) stranded RUNNING.lock and left read_verdict polling forever. Failure accounting now lives outside the wrapper. - harnessd's patch allowlist ignored git rename/copy headers and --no-prefix diffs; the rename-escape case is now a committed regression test. - The workspace did not compile on Windows (ungated Unix APIs). cfg-gated; 71 portable tests now run on both platforms. - pin-check regenerated the corpus manifest instead of verifying it; it is now verify-only, with a deliberate `just pin-corpus` to re-pin. - Max RSS is captured per run on Unix; PMU counters are opt-in diagnostics (compare --perf-stat), never part of the accept decision. Docs now match the code, including what is NOT yet enforced: no target ships a TESTSUITE.sha256 pin, no target declares [build].tsan, and matmul is not wired to the fp-tolerance gate — each is stated as mechanized-but-inert rather than done. Corrected the stale "33 ledger rows" (34), the playbook's class-3 cJSON win (rejected), adversarial-review.md's sanitizer-separation claim (five accepted rows carry sanitizers_clean=false), the unsupported "40,000 requests" figure, and the blanket "historical rows record fuzz_iters=0" (8 of 10; phase0-tokei-002/-003 record 4,332). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
@@ -21,7 +21,7 @@ hostile review.
|
||||
## Verified results
|
||||
|
||||
Every number carries its 95% CI and its workload, and every one survived the
|
||||
gates above. Across **five phases and 33 ledger rows, zero shipped false
|
||||
gates above. Across **five phases and 34 ledger rows, zero shipped false
|
||||
accepts** — including two pipeline over-accepts the audit caught before
|
||||
anything shipped, each becoming a permanent new gate.
|
||||
|
||||
@@ -58,11 +58,16 @@ docs/ The mdBook site (deployed to GitHub Pages)
|
||||
just build / test / lint # trust-layer workspace
|
||||
just aa # A/A self-test — must yield a null verdict
|
||||
just gates <target> # corpus pin + upstream tests + golden replay
|
||||
just verdict <t> <bin> ... # gates + bench vs pristine baseline + ledger row
|
||||
# (fuzz needs a baseline — it runs in `just verdict`)
|
||||
just verdict <t> <bin> ... # gates + fuzz + sanitizers + bench vs pristine baseline
|
||||
just report <run-id> # ROI report from a ledger row
|
||||
just isolation-check # 19 OS-boundary checks (both modes)
|
||||
```
|
||||
|
||||
The pipeline is **Linux/POSIX-only** at runtime (Unix sockets, `setsid`,
|
||||
sh-based gates). Windows builds the workspace and runs the portable unit
|
||||
tests, but cannot run the pipeline.
|
||||
|
||||
Full command reference and reproduction steps:
|
||||
[Reproduce it yourself](https://bdbrown4.github.io/peltier.io/reproduce.html).
|
||||
|
||||
|
||||
Reference in New Issue
Block a user